https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24788
Bug ID: 24788
Summary: Koha::Object->store calls column names as methods,
relying on AUTOLOAD, with possibly surprising results
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Koha::Object->store accesse sDBIx::Class::Row columns as $self->$col, using
AUTOLOAD, which in effect makes column names and methods share the same
namespace. I'm no security expert, but I think this should be considered bad
practice and could be an attack vector. It also has huge potential for causing
strange bugs, which happened in Bug 14957 where a column is named "delete",
calling the "delete" method instead of fetching the column value as intended.
Here is patch to fix this using a separate namespace for setting/getting
columns through get_column/set_column instead.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
