https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24594
--- Comment #5 from Jonathan Druart <[email protected]> --- Bernardo, I am letting here the QA notes for the whole stack (I rebased my remote branch btw, there were 2 minor conflicts due to copyright changes). 1. There are some QA issues: FAIL installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.yml FAIL yaml_valid YAML Error: Inconsistent indentation level FAIL installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml FAIL yaml_valid YAML Error: Inconsistent indentation level FAIL installer/data/mysql/en/marcflavour/marc21/optional/marc21_default_matching_rules.yml FAIL yaml_valid YAML Error: Inconsistent indentation level FAIL installer/data/mysql/en/marcflavour/marc21/optional/marc21_sample_fastadd_framework.yml FAIL yaml_valid YAML Error: Inconsistent indentation level FAIL installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.yml FAIL yaml_valid YAML Error: Inconsistent indentation level 2. I did an install 'en' before and after the patchset, I mysqldump --tab to generate 2 files per table, then compared the 2 generated directories with `diff -r --brief` (and also a `perl -p -i -e "s/.*Dump completed.*//" **/*` to remove timestamp of the dump). Most of them are wrong diff because of different timestamps, but some of them are either weird, or caught issues: a) When a row is on several lines, I get, for instance with letter "TO_PROCESS": 652,657c652,657 \ suggestions TO_PROCESS Notify fund owner 0 A suggestion is ready to be processed Dear <<borrowers.firstname>> <<borrowers.surname>>, \ \ A new suggestion is ready to be processed: <<suggestions.title>> by <<suggestions.author>>. \ \ Thank you, \ --- > suggestions TO_PROCESS Notify fund owner 0 A > suggestion is ready to be processed Dear <<borrowers.firstname>> > <<borrowers.surname>>,\ > \ > A new suggestion is ready to be processed: <<suggestions.title>> by > <<suggestions.author>>.\ > \ > Thank you,\ > \ Without the patch: 656 Thank you,\ With the patch: 656 Thank you,^M\ I am not sure how relevant is this, the UI looks correct. b) matcher_matchpoints is different: without: 1 1 2 2 3 3 with: 3 1 3 2 3 3 c) false positive: search_field, search_marc_to_field and search_marc_map (because of id loaded in a different way), this is coming from: installer/install.pl: Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings; Not related to this patchset. d) subscription_numberpatterns (to investigate) 1c1 < 1 Number 1 Simple Numbering method No. {X} Number 1 1 99999 1 \N \N \N \N \N \N \N \N \N \N \N --- > 1 Number 1 Simple Numbering method No. {X} Number 1 1 > 99999 1 \N \N \N \N \N \N \N \N > \N \N \N \N \N 3,4c3,4 < 3 Volume, Number 3 Volume Number 1 Vol. {X}, No. {Y} Volume 1 12 99999 1 \N Number 1 1 12 1 \N \N \N \N \N \N < 4 Seasonal 4 Season Year {X} {Y} Season 1 1 3 0 season Year 1 4 99999 1 \N \N \N \N \N \N --- > 3 Volume, Number 3 Volume Number 1 Vol. {X}, No. {Y} Volume > 1 12 99999 1 \N Number 1 1 12 1 > \N \N \N \N \N \N \N > 4 Seasonal 4 Season Year {X} {Y} Season 1 1 > 3 0 season Year 1 4 99999 1 \N \N > \N \N \N \N \N e) systempreferences (to ignore) There is an obvious change here on "FrameworksLoaded", the list of sql files is replaced with a list of yml files. I did not know this pref existed, it seems to be used to make sure we are not going to load twice the same files. We can ignore this one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
