http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437
--- Comment #8 from Jared Camins-Esakov <[email protected]> --- (In reply to comment #7) > This patch fixes errors under plack but doesn't work for large backup files. > > The problem is in download_backup which tries to print data back to browser > in 64K chunks. Under plack, that gets buffered in memory and with backup of > our production database it dies after a while and returns zero length file. > > Correct way to fix this is to issue redirect under plack in download_backup > to some plack handled URL so we don't read whole file in memory. > > I don't know how to detect plack if we are running under plack since script > is inside CGI::Compile, but we could use environment variable to signal that > we are under plack. > > That would, however, require us to have some kind of koha.psgi in which we > can implement this in master. I guess the thing to do is note that this is not available under Plack? > I also had to remove > > && not $filename =~ m#|# > > from download_backup to make download work at all, so I will have to remove > signed-off on this patch, sorry. There's a signed off patch which makes that last change on bug 8268. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
