http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963

Jonathan Druart <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |m

--- Comment #11 from Jonathan Druart <[email protected]> ---
QA Comments (before Sign-off):

1/ Why don't you remove the old script? (check-url.pl)
2/ Please replace
  +use 5.010;
  +use strict;
  +use warnings;
with use Modern::Perl;
3/ It seems in Koha, the scripts have an extension. Please add the .pl
4/ It would be great to pass an argument (or syspref :-/) to the script
containing a list of field to check ? In UNIMARC, we can have 316$u, 317$u,
464$u, etc. with urls.
5/ For a new script it is very nice to submit the patch after a perltidy ;)

1, 3 and 5 are mandatory to pass QA

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to