https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24745
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100152|0 |1 is obsolete| | Attachment #101558|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <[email protected]> --- Created attachment 101586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101586&action=edit Bug 24745: OPAC news block plugin should evaluate as false if there are no items This patch changes the way news is returned from GetNewsToDisplay in KohaNews.pm so that the template variable will evaluate as false instead of simply being an empty data structure. To verify the bug, remove your opacheader news entry and view source on any page in the OPAC. You should find some empty markup right after '</div> <!-- /navbar -->' <div class="container-fluid"> <div class="row-fluid"> </div> </div> To test the fix, apply the patch and reload the OPAC page. The empty divs should be gone. Add content to the opacheader news item and confirm that it displays correctly. Signed-off-by: Bernardo Gonzalez Kriegel <[email protected]> Divs gone, no errors. Signed-off-by: Marcel de Rooy <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
