https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
--- Comment #116 from Lari Taskula <[email protected]> --- Comment on attachment 101934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101934 Bug 15522: Add API for circulation rules Review of attachment 101934: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15522&attachment=101934) ----------------------------------------------------------------- ::: api/v1/swagger/paths/circulation-rules.json @@ +28,5 @@ > + "schema": { > + "$ref": "../definitions.json#/error" > + } > + } > + } No permissions required for GET? @@ +40,5 @@ > + ], > + "parameters": [{ > + "name": "body", > + "in": "body", > + "description": "A JSON object containing rules to set; null for a > rule_value means to delete the rule", I think this wrong functionality for POST method that is supposed to create resources. Also, by definition POST is not idempotent, but here it seems to be. (If I understand the API correctly, here making the same request twice is the same as making it only once, right?) It should then be PUT. But PUT requires the whole object as a parameter. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
