https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #53 from Jonathan Druart <[email protected]> --- Copy/pasting a comment from bug 24980 (I sent it to the wrong bug number): """ Hi Jonathan, (In reply to Jonathan Druart from comment #11) > 0. Dates look great now! :) > > 1. Why not having current holds in the table (behavior intranet-side, > members/holdshistory.pl) Controller uses object.search, and places order by in dbic.. to replicate current behaviour in intranet I should one object.search for both current and old holds, merge and sort both arrays depending on search column... I decided to wait till requests and old_requests tables were merged to have current intranet behaviour > > 2. Is there a plan to make existing intranet-side view using the REST API? > ie. only 1 code to maintain. > Once we can replicate current intranet behaviour, we can think on changing intranet-side > 3. Why only 10 results displayed by default? Usually 20 > ok, will change that > 4. Why no way to modify the number of results displayed? Basically, why > DataTable does not display as other table? (like no page number, search box, > etc.) > Is that the OPAC style? > OPAC has no style for DataTables.. only intranet has. What you see in other tables in OPAC was coded outside DataTables. I thought it best to have a search box and page number, but I'm open to suggestions. > 5. Not translatable strings: > 187 if(row.cancelation_date) return 'Canceled'; > 188 if (data == 'F') return 'Fulfilled'; > 189 if (data == 'W') return 'Waiting'; > 190 if (data == 'T') return 'In Transit'; > 191 return 'Pending'; > Good catch.. will fix that > 6. opac-holdsrecord.pl vs members/holdshistory.pl > Should not we use the same script names? copied the name from opac-readingrecord, but it can be changed Comment 14 AgustÃn Moyano(reporter)(assignee) 2020-03-30 17:53:20 CEST (In reply to Jonathan Druart from comment #12) > 7. Should not deal with that in js-date-format.inc? > (data&&$date(data))||''; ok, it can be done """ -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
