https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24980
--- Comment #22 from Jonathan Druart <[email protected]> --- (In reply to Agustín Moyano from comment #20) > (In reply to Jonathan Druart from comment #18) > > How do I test the timezone handling in real life? ie. without using the > > console. > > Actually there is no place (even bug 20936) that brings timestamp or > datetime. If you want to try to see if it works with koha's configured > timezone you should use the console without the tz option, then format a > datetime with timezone. Later change koha's timezone, restart plack and > reload the page and try to format the same datetime, it should change > according to the new timestamp > > If it works in the console, it should work on real life (it's the same > function) Do we need it then? (In reply to Agustín Moyano from comment #21) > (In reply to Martin Renvoize from comment #19) > > I initially liked that final patch.. but do we believe it's correct > > consistency wise given that dt_from_string (which we're using in KohaDates > > which with function is emulating) will return 'now' when passed 'undef'. ? > > In my opinion, if the API's date is null, we shouldn't return current date. I agree, this patch looks good to me. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
