https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #179 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Created attachment 102364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102364&action=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com> Signed-off-by: David Nind <da...@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/