https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887

--- Comment #15 from Lari Taskula <[email protected]> ---
Comment on attachment 101890
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101890
Bug 22887: Warn if duplicates exist

Review of attachment 101890:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22887&attachment=101890)
-----------------------------------------------------------------

::: installer/data/mysql/atomicupdate/bug_22887.perl
@@ +7,5 @@
> +            GROUP BY category, authorised_value
> +            HAVING c > 1
> +        |, { Slice => {} });
> +        if ( @$duplicates ) {
> +            warn "WARNING - Cannot create unique constraint on 
> authorised_value(category, authorised_value)\n";

Nice to give a warning. We should still make sure the constraint actually gets
created for everyone.

Perhaps delete the duplicates and print & log what was deleted?

Or die instead of warn.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to