https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571

--- Comment #16 from Tomás Cohen Arazi <[email protected]> ---
(In reply to Jonathan Druart from comment #10)
> A couple of things:
> 1. test plan says "the second one fails", but it actually prints. I would
> die instead.
> 2. That will make you avoid the indentation level you add with this patch.
> The algo would be:
> - try to get a lock
> - if lock already exists then exit/die with "cannot get lock" (or something
> more meaningful: "previous run is still alive, cannot start")
> - continue the normal process of the script

Solved in my alternative patch. I chose to keep the output silent, unless
--verbose is passed. This is the right behaviour for cronjobs, specially if we
have the execution logged in the action_logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to