https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy <[email protected]> --- Some QA comments: use Modern::Perl Where do you need FindBin for here? I understand the test on enable_plugins but I feel that it should be part of GetPlugins somehow. If you did not enable them, GetPlugins should take care of it and return nothing. The if(@plugins) is not needed. You are looping thru @plugins inside. Why do you warn $_ ? Second patch If you are adjusting the debian koha-conf, you should also touch the other one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
