https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
--- Comment #72 from Agustín Moyano <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #71) > (In reply to Josef Moravec from comment #68) > > Comment on attachment 103950 [details] [review] [review] > > Bug 20936: Add patron's hold history menu in OPAC > > > > Review of attachment 103950 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: Koha/REST/V1/Patrons/Holds.pm > > @@ +61,5 @@ > > > + my $holds = $c->objects->search( $holds_set ); > > > + return $c->render( status => 200, openapi => $holds ); > > > + } > > > + catch { > > > + $c->unhandlede_exception($_); > > > > typo, should be unhandled_excecption > > Done! > > > @@ +118,5 @@ > > > +[% INCLUDE 'datatables.inc' %] > > > +[% INCLUDE 'js-date-format.inc' %] > > > +<script> > > > + $(document).ready(function(){ > > > + [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END > > > %] > > > > Why Google Jackets and not other services? > > That didn't make any sense, I cleaned it. > > > ::: opac/opac-holdshistory.pl > > @@ +33,5 @@ > > > +use Koha::Patrons; > > > + > > > +use Koha::ItemTypes; > > > +use Koha::Ratings; > > > + > > > > You don't need most of these imports > > Cleaned the .pl on behalf of Agustin. Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
