https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279
--- Comment #19 from Jonathan Druart <[email protected]> --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Jonathan Druart from comment #17) > > 1. Small UI changes (not advertised) > > > > Before: https://snipboard.io/cRdEWA.jpg > > After : https://snipboard.io/qep6rS.jpg > > > > a) No more pagination (should be restored imo) > > Pagination works, it just doesn't have pages. Yes, I did not say it did not work. The pages should be displayed imo. > > d) Table is displayed even if empty > > I don't think this is a problem. The only solution is to count them in the > controller .pl before rendering the page. Would you agree with such approach? Maybe something DT-side to handle that? > > e) Default number of entries was 10, not 20 (better as it) > > Will fix, this is configurable. No, 20 is correct. > > 3. Why the indentation changes in cities.json? > > I think my editor did that when I intended to re-indent the portion I added. > Is it a problem? No, I wanted to know if the existing syntax was a problem for something. We should prevent such unnecessary changes (no blocker here). > > 4. We reached a point where we don't have XSS issue in our templates, all > > variables are correctly escaped. > > With this adding more JS code we should continue to enforce the rule, all > > the variables must be correctly escaped. > > You mean data that comes from the API???? I did not investigate it, I don't know where it's best to escape them. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
