http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044
M. de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |[email protected] --- Comment #20 from M. de Rooy <[email protected]> --- Signing off the patch and reviving the discussion with the following remarks: The patch adds a dependency: Locale::Maketext,Locale::Maketext::Lexicon. Should be added to PerlDependencies, etc. I tested the translation with some $lh->maketext call. (Note that the test patch has a conflict.) This works. When creating a messages-po file, the charset CHARSET is inserted. Can this be prevented? If the user does not correct it, the update process will generate warnings: Charset "CHARSET" is not a portable encoding name. Message conversion to user's charset might not work. If there are no messages to translate, you will generate the error: /usr/bin/msgmerge: error while opening "/usr/share/koha/testclone/misc/translator/po/nl-NL-messages.po" for reading: No such file or directory. This pseudo error can probably be prevented by some simple additional check on existence. Finally, I did not see a (counter) patch with TextDomain. So I could not look at both sides. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
