http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412
--- Comment #32 from Matthias Meusburger <[email protected]> --- It probably should be = [ .. ]; The cookie parameter of CGI accepts an arrayref. Please correct. -> fixed Just a question, did not examine this further. But should you use uri_escape_utf8 instead of uri_escape? Please test on chars in 128..255 and above, and report back. -> I've tested with the following chars: É À œ Œ ñ … as well as with some cyrillic: Советский Союз And it does behave correctly. But it also behave correctly with uri_escape_utf8. I changed to code so it uses uri_escape_utf8, which seems safer. Indentation: additem.pl lines 356 to 360; the same for segment 426-442 (followup..) -> fixed You are adding this comment somewhere: This code is subject to change in 3.2 That sounds a little bit old now? In the new code you add code for incrementing barcode. Note that additem already contains subroutine _increment_barcode. Why not use that? Followup? -> fixed -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
