https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591
--- Comment #13 from Nick Clemens <[email protected]> --- (In reply to Jonathan Druart from comment #12) > Comment on attachment 99980 [details] [review] > Bug 21591: Check for record level item type issues too > > Review of attachment 99980 [details] [review]: > ----------------------------------------------------------------- > > ::: misc/maintenance/search_for_data_inconsistencies.pl > @@ +89,4 @@ > > > > my @itemtypes = Koha::ItemTypes->search->get_column('itemtype'); > > if ( C4::Context->preference('item-level_itypes') ) { > > + my $items_with_invalid_itype = Koha::Items->search( { -and => > > [itype => { not_in => \@itemtypes }, itype => { '!=' => '' }] } ); > > I do not think we need that change. @itemtypes contains the values from the > itemtypes table. I see what I did here, I add the check for "" to the check for 'Items do not have itype defined' I considered a blank string to be 'unset' and so report in that section rather than in 'invalid' section -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
