https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229
--- Comment #10 from Tomás Cohen Arazi <[email protected]> --- (In reply to Jonathan Druart from comment #9) > (In reply to Jonathan Druart from comment #5) > > Not directly related, but I noticed that we return ALL the items from the > > DB, and it is what the tests expect: > > > > 75 $t->get_ok( "//$userid:$password@/api/v1/items" ) > > 76 ->status_is( 200, 'SWAGGER3.2.2' ); > > 77 > > 78 my $items_count = Koha::Items->search->count; > > 79 my $response_count = scalar @{ $t->tx->res->json }; > > 80 > > 81 is( $items_count, $response_count, 'The API returns all the items' > > ); > > > > Wondering if this is correct. If not please open a separate bug report. > > Tomas, can you answer this question please? > > As I said yesterday during the dev meeting, it would mean that one could > call 6 times the GET /items route to kick the server down? I think I did on my commit message, Jonathan. I'll rephrase. Test::Mojo creates a user agent that is used internally. This user agent has a low timeout. Loading the V1.pm app in Test::Mojo is not the same as loading it with Plack and I'm not sure about the internals. This is not different than running a badly written report that takes too much. It might keep a starman worker busy for too long, etc. I think we need to force pagination and at some point I was sure we did. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
