https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Julian Maurice <[email protected]> --- (In reply to Katrin Fischer from comment #9) > This is working well for me and is a really nice addition. > > Wondering 2 things: > - We got a system preference for turning on/off patron attributes. Should > the column not be visible when the pref is turned off? > (ExtendedPatronAttributes) I added checks for this syspref. The column should be hidden now when syspref is disabled > - The display_value method somehow looks not quite right to me. I think this > may be what Jonathan was trying to point out in his comment, that there > could be another way of doing it. Could you take a look and comment? I removed it. There is now a 'description' method which does the same thing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
