https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25587
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105285|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <[email protected]> --- Created attachment 105566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105566&action=edit Bug 25587: fix for "clear" button to reset all selects Button "clear" on cgi-bin/koha/admin/smart-rules.pl did not reset fields with a dropdown selector except the first one. This happens because jQuery selector .find("select option:first") in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt selects only single first element in the whole group, as from jquery doc: > The :first pseudo-class is equivalent to :eq( 0 ). It could also be > written as :lt( 1 ). While this matches only a single element, > :first-child can match more than one: One for each parent. > (https://api.jquery.com/first-selector/) And it works if replaced by: .find("select option:first-child") To reproduce: 1) Go to /cgi-bin/koha/admin/smart-rules.pl 2) Start editing one of existing rules or filling a new one, change all selects to have non-first option selected. Fill text input fields with sample data. 3) Reset all fields with the "clear" button. 4) Observe that only the first dropdown field was reset to the first option while all others still contain previously given values, meanwhile all text input fields are cleared as expected. 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Check that all dropdown fields were reset to first option, as expected. Mentored-by: Andrew Nugged <[email protected]> Signed-off-by: Lucas Gass <[email protected]> Signed-off-by: Julian Maurice <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
