https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554
--- Comment #5 from Andrew Nugged <nug...@gmail.com> --- Here we need to have more filtering criteria for smart-rules. For Finnish libraries, we added "ccode" and "sleving_location", two extra smart rule filters (but by the way also later we propose this for the community version) so we had before: my $scope3 = [ 'branchcode', 'categorycode', 'itemtype' ]; but now we have in our case: my $scope3 = [ 'branchcode', 'categorycode', 'itemtype', 'ccode', 'shelving_location' ]; and because of having only a single variable, we don't need to change any variable names down in the file, nor copy-paste dozen times like it is now the same array copypasted everywhere. But now proposal from Jonathan to name it something like "$branch_category_itemtype" will make this: my $branch_category_itemtype = [ 'branchcode', 'categorycode', 'itemtype' ]; becoming this (???): my $branch_category_itemtype_ccode_shelving_location = [ 'branchcode', 'categorycode', 'itemtype', 'ccode', 'shelving_location' ]; so when we add two extra items, we should again change all the code down below to the new variable name $branch_category_itemtype_ccode_shelving_location? Yikes! That's why we voting for "$scope3", because we have three scope sections, even logically separated: small one, middle, and full. ... Oh, or let's name it "$scope_full" if you ok? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/