http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454
--- Comment #5 from David Cook <[email protected]> --- I figured the "if ( 1 ){}" approach would be the easiest, as it meant the fewest changes to the code, but I'm certainly up for alternative strategies :). I'm not sure that I understand your conditional here though. Doesn't that say that $run_report will be 1, if $input->param('run_report') isn't set/defined? Otherwise, if it is defined...then it will just be the param that's passed, which amounts to 1 anyway? In either case, it seems inevitable that the page will load the report upon page load, which I'm proposing is a good idea. However, in that event, how would it be possible for someone to load this page without running the report, as you suggest? (In reply to comment #4) > QA Comments: > > Your patch is the same as > if ( 1 ){} > > I think a better way to do this is : > my $run_report = ( not defined $input->param('run_report') ) ? 1 : > $input->param('run_report'); > > If someone wants to load this page without running the report it is possible. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
