http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Paul Poulain <[email protected]> --- QA comment: I was about to push your patch (after squashing the 2 last follow-up and adding a removal of useless `` in updatedatabase), and, at the end, I won't, because I've found a tiny mistake: The update says: UPDATE statistics SET statistics.ccode = ( SELECT items.ccode FROM items WHERE statistics.itemnumber = items.itemnumber ) which seems OK OTOH you record a ccode only in Circulation.pm, which seems OK (you don't need to record the item ccode when a fine is paid, so nothing changed in C4::Accounts.pm) BUT: when you pay a fine because of a lost item, the itemnumber field *can* be set. In this case, you will have an itemnumber, but no ccode. Your updatedatabase will populate ccode anyway. So, 2 options: * populate ccode in Accounts.pm, when there is an item * UPDATE by discarding statistics.type='payment' or 'writeoff' (maybe there are other values, not 100% sure) Please choose and resubmit. I suggest you squash the 4 current patches, and add a follow-up for this QA question -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
