https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407
--- Comment #16 from Julian Maurice <[email protected]> --- (In reply to David Cook from comment #15) > If it doesn't die, what happens if you want to add a check to that object? > Maybe you only want to return the guarantor under certain conditions. It > probably makes sense to add that check here rather than in every caller of > this method. To do that, you'd have to refactor to use the syntax I > described anyway. Or maybe you're doing some debugging because the guarantor > being returned isn't correct. You can't add any logging in this code unless > you refactor to the syntax I described. In my opinion "maybe we will want to add something here" is not a good reason to refactor code. If that "maybe" ever comes true, then you can refactor the code while making the change. No need to do it now. Note that I also tend to prefer your version, but I'm happy with both. If it ain't broke don't fix it ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
