https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #15 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
---
Salut Julian,
Could you add a unit test and replace
+ $patron->{attributes} = Koha::Patron::Attributes->search({
borrowernumber => $patron_object->borrowernumber });
with a call to $patron->extended_attributes?
Also a question:
const extendedAttributesColumnIndex = columns_settings.findIndex(column =>
column.columnname === 'extended_attributes');
columns_settings.splice(extendedAttributesColumnIndex, 1);
findIndex returns -1 if not found. It should not happen I'd say, but should not
we prevent side-effects and check if extendedAttributesColumnIndex != -1?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
