https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |ommunity.org Assignee|[email protected] |[email protected] |ity.org | --- Comment #7 from Jonathan Druart <[email protected]> --- 1. I would not create a separate test file RelatedObjects.t code can be moved to a subtest of Koha/Items.t 2. On your way, you could create a Koha::Hold->library and ->patron. ->branch and ->borrower will call ->library and ->patron branch and borrower could be marked as deprecated 3. In holds-table.inc, + Item in transit to <strong> [% HOLD.branch.branchname | html %]</strong> <input type="hidden" name="pickup" value="[% HOLD.branchcode | html %]" /> It's weird to access HOLD.branch.branchname and HOLD.branchcode (better HOLD.branch.branchcode to highlight it's the same object we access). I think it make more sense to have a "library" variable, [% SET library = HOLD.branch %] then reuse library for branchcode and branchname attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
