https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #119 from Katrin Fischer <[email protected]> --- Hi Maryse, I am no expert on the guarantor features, mostly because we work with academic libraries that have no children and the limitation on the relationships at the moment. So I am interested in this one, but still learning how it all fits together. 1) Conflict of system preferences? Current Koha has the PrefillGuaranteeField system preference that appears to achieve the same as GuarantorFields added by this patch set. Can you please check and explain if there is a difference in behaviour? Please adjust the commit message with the test plan (either remove or update the pref name) 2) Not only adults I believe this patch goes even further than the initial description: it will enable patron categories from all category types to be able to act as guarantees (not only adults). So it will allow arbitrary relationships? We should adjust the bug title, if I am right about this. Maybe "Ability to allow guarantor relationship for all patron category types" ? 3) Children can be guarantors? This seems to be the case before your patch set: Searching for a guarantor doesn't seem to have any limits. You can use child patrons as guarantor. No change required - just noting as this might be worth discussing separately. 4) Guarantees fines display I am not quite happy with the table used for display, I think it doesn't work very well with the rest of the page. We also often get asked to hide anything fine related for libraries not using fines. It would be nice if the information only showed up when there are actually fines. We should at least add an id and maybe some classes. Attaching a screenshot later. 1) is the blocker here - please check! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
