https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26108
--- Comment #4 from Tomás Cohen Arazi <[email protected]> --- Created attachment 107640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107640&action=edit Bug 26108: Regression tests The current implementation makes the assumption that if $issue is defined, then it is the 'return' use case. This is correct, but incomplete: after verifying that there's actually an issue, the return can be rejected for various reasons. This patch introduces a regression test for one of those situations (which I consider enough for testing purposes) . It highlights that the hook shouldn't be called if there hasn't been an actual checkin. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Circulation_hooks.t => FAIL: Tests fail because there's an unexpected warining printed by the erroneous plugin call (i.e. there's been no return but the plugin is called anyway). Signed-off-by: Tomas Cohen Arazi <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
