https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112
Lari Taskula <lari.task...@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105788|0 |1 is obsolete| | --- Comment #10 from Lari Taskula <lari.task...@hypernova.fi> --- Created attachment 107651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107651&action=edit Bug 25112: Make set_rules() handle rule scopes Koha::CirculationRules->set_rules is currently too complicated to use. Right now, in order to specify multiple rules at once, they must all be rules that accept the same set of scopes. Otherwise we can get this type of errors: 1/9 set_rule cannot set 'holds_per_record' for a 'checkout_type'! at t/db_dependent/Circulation/GetHardDueDate.t line 215. Validating scopes at set_rule() is good, but set_rules() should examine each rule and pass the correct scope to set_rule() instead of passing all scopes to every rule like it is doing now. To test: 1. prove t/db_dependent/Koha/CirculationRules.t 2. Observe success Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/