https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408
Nick Clemens <n...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Nick Clemens <n...@bywatersolutions.com> --- This seems to be affecting the staff side as well To test: 0 - Apply patches 1 - Set rule to "Don't allow" item specific holds on opac 2 - Attempt to place hold on staff side 3 - Hold is not allowed 4 - Change rule to 'force' 5 - Hold can be placed I worry about this line: return { status => 'OK' } if ( $canReserve->{status} eq 'notReservable' && $opacitemholds eq 'N' ); as it short circuits some other checks, but I think the scripts end up double checking and it is not a problem. Other that that all the login in the scripts should be in the modules ;-) > afaik the most strict is enforced in the GUI (which makes sense to me) I talked this over with Andrew, there doesn't seem to be a perfect way to do this, but as long as this patch isn't changing current rules I think we are good Can we get a more detailed test plan covering the cases on opac and staff side? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/