https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889
--- Comment #60 from Jonathan Druart <[email protected]> --- Scratching my head, is the following condition correct? C4::HoldsQueue::MapItemsToHoldRequests 409 next 410 if ( !$item->{holdallowed} ) 411 || ( $item->{holdallowed} == 1 412 && $item->{homebranch} ne $request->{borrowerbranch} 413 || $item->{_object}->exclude_from_local_holds_priority ); Should not we exclude it in any cases? It's correct but read it is confusing, I would expect it to be more explicit: 409 next 410 if !$item->{holdallowed} 411 || ( $item->{holdallowed} == 1 412 && $item->{homebranch} ne $request->{borrowerbranch} ) 413 || $item->{_object}->exclude_from_local_holds_priority -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
