https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <[email protected]> --- Starting with a first round of testing and reviewing here: 1) Database update I feel it would be cleaner to do the same check for the old_reserves table as well: if( !column_exists( 'reserves', 'non_priority' ) ) { 2) GUI request.tt a) I am not sure of a 'non priority hold' is a standing term, but I haven't seen this feature in another ILS before. I think maybe having an explanation in a tool tip or after the checkbox could be quite helpful here. I'd also suggest to add an ID to the <li> to help libraries hide this functionality if they don't intend on using it: + <li> + <label for="non_priority">Non priority hold:</label> + <input name="non_priority" id="non_priority" type="checkbox" /> + </li> b) Once the hold is placed, there is no way to visually tell that it's a non-priority hold. I think this could lead to support questions and we will only be able to figure it out looking at the database entry. I'd strongly recommend to add a note to request.tt and to the hold list in the patron account on staff side. On request.tt this could go into the Details column. 3) More than one hold My test case: - Check out item to Henry - Place a non-priority hold for admin - Henry can still renew - Place another hold for a regular staff patron - Henry can still renew... I feel like it needs to look at all holds and not only the next one? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
