https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357
--- Comment #64 from David Cook <[email protected]> --- (In reply to Joonas Kylmälä from comment #63) > even if I apply the patches on top of the Koha version from the day the > patches were submitted I get: > > Applying: Bug 16357: (follow-up) Use Koha::Logger and add fatal errors > error: sha1 information is lacking or useless (debian/templates/plack.psgi). > error: could not build fake ancestor > Patch failed at 0001 Bug 16357: (follow-up) Use Koha::Logger and add fatal > errors Which patch set did you try? Your comment isn't clear. > Also the dependency is unclear in both alternative patches for > libplack-middleware-logwarn-perl, does the latter alternative need it also? > Either way, the dependency should be probably added to cpanfile since > debian/control is autogenerated and should not be tweaked manually. I'm fine > with the latter alternative approach btw, so please just resubmit that since > I was under the impression David preferred that too. Yes, both patches marked [Alternative] are part of the same patch set. I think the dependency is clear. They both must be applied as per the test plan below: To Test: 0) apt-get install libplack-middleware-logwarn-perl 1) Apply "Alternative" patches 2) Copy PLACK block from etc/log4perl.conf to /etc/koha/sites/kohadev/log4perl.conf and replace __LOG_DIR__ appropriately 3) Copy debian/templates/plack.psgi to /etc/koha/sites/kohadev/plack.psgi 4) Temporarily add 'warn "TEST"' to opac-main.pl and mainpage.pl 5) koha-plack --restart kohadev 6) Go to /cgi-bin/koha/mainpage.pl and /cgi-bin/koha/opac-main.pl 7) Open /var/log/koha/kohadev/plack-opac-error.log and /var/log/koha/kohadev/plack-intranet-error.log 7) Observe a log line like the following: [2020/06/22 03:51:23] [WARN] TEST at <SCRIPT and line #>. Re: debian/control, I hadn't heard definitively from the QA/Release team about that. I notice you were added to the QA team for 20.05. Can you confirm that all dependencies should be added via the cpanfile? I'm happy to resubmit moving the debian/control change to the cpanfile. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
