https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26163
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #21 from Kyle M Hall <[email protected]> --- (In reply to Galen Charlton from comment #18) > The patch works for me with the curbside pickup plugin, and I'd be > comfortable treating the kitchen sink plugin as not handling its interior > modules as it should. Consequently, I've attached my signoff and tweaked the > commit message a bit. > > That said... this may not be necessary after all. I've worked out an > approach to have plugins register their own custom DBIx result classes > without requiring that koha-plack munge PERL5LIB in advance. See the pull > request on the plugin here: > > https://github.com/bywatersolutions/koha-plugin-curbside-pickup/pull/7 > > If that pull request holds up, the approach it outlines may well obviate any > need for Koha itself to change. Consequently, I'm setting the bug status to > in discussion for the moment. This is fantastic Galen! Thanks! I've merged your pull requests into the plugin. I am quite happy to close out this bug report, as Galen's solution is definitely the better one. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
