http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597
--- Comment #51 from Paul Poulain <[email protected]> --- Even if I discard the QOTD thing, that is minor, there's something that is annoying me with this patch, I'll try to share what. My main question = why does it add a new template, and not just the mobile stuff ? Activating the mobile support means activating ccsr template AND updating opaccolorstylesheet sysprefs. wouldn't the 1st patch + +<meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum-scale=1.0,user-scalable=no"> +<link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" href="[% themelang %]/css/mobile.css" /> + a prog/css/mobile.css (+ a few other markup changes probably) have achieved the same result ? I think we're doing 2 things in the same patch, and it wrong. I made a little bit test that worked quite well: * applied all patches * set opacthemes=prog * nothing in opaccolorstylesheet * added the 2 previous lines to koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc * copied the mobile.css into prog/ directory => it works well ! (except a few glitches that could be improved later. As conclusion: * the 2 previous lines must be added to this patch to enable mobile support for prog templates, with mobile.css, and tweaking it to solve minor problems. * adding the cssr theme itself is debatable, but i'm not sure it's a good idea to add it = it has been proven over time that maintaining 2 sets of templates is *very* hard. If cssr want to use it's own set, I'm fine with it. But maintaining both sets on official Koha should be a community decision, not something we introduce without warning. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
