https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26256
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109771|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <[email protected]> --- Created attachment 109938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109938&action=edit Bug 26256: Move translatable strings out of templates and into serials-toolbar.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and go to Serials and search for a subscription. - Open the detail page for an open subscription. - Click the "Close" button. You should get a confirmation, "Are you sure you want to close this subscription?" - Confirm that you want to close it. - When the page reloads, click the "Reopen" button. You should get a confirmation, "Are you sure you want to reopen this subscription?" - Cancel. - Choose Edit -> Delete subscription. You should get a confirmation, "Are you sure you want to delete this subscription?" - Perform the same tests from the "Serial collection" page. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/serials-toolbar.js for translation, e.g.: msgid "Are you sure you want to delete this subscription?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: Alexis Ripetti <[email protected]> Signed-off-by: Julian Maurice <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
