https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #171 from Kyle M Hall <[email protected]> --- > 1) QA tools: > > FAIL cataloguing/additem.pl > FAIL valid > "my" variable $item masks earlier declaration in same scope Fixed! > 2) Unit tests > > Ran the database update, but tests are failing: I wasn't able to recreate your unit test failure. Can you try again? > 3) Methods > > libraries_where_can_see_patrons is added to Patron.pm > I am not sure how it fits into this functionality, maybe a leftover from an > earlier development? This subroutine is from Jonathan's patch that added group limits for viewing patrons. This patch set takes that logic and makes it more generic for use with other objects that also have branchcodes. libraries_where_can_see_patrons is the specific implementation for jonathans previous feature, which is now a wrapper around the more generic method that can also be used for items and other objects in the future. > 4) Item edit checks > > I think we might also need a check on the permission from the item search > edit item link. I've been working on this patch, but it occurs to me that the edit item link shows even if a record has no items. It's a useful way to go straight to the items editor to create a new item. As such, I don't think we should hide the link because it can still be used in that way even if the librarian can't edit any existing items. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
