http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215
Jonathan Druart <jonathan.dru...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jonathan.dru...@biblibre.co
| |m
--- Comment #46 from Jonathan Druart <jonathan.dru...@biblibre.com> ---
QA Comments:
Great patch :)
Code clean and easy to read.
Some remarks:
Blocker:
* perlcritic does not pass on course_reserves/add_items.pl:
Variable declared in conditional statement at line 60, column 5. Declare
variables outside of the condition. (Severity: 5)
easy to solve.
* It would be good to have an information (close to "Department" and "Term" on
the create course page) to explain how to add departments and terms.
not blocker:
- There is a "dot" before the li element of the instructor result list
(overflow).
- the edit is on the course.pl and redirects to mod_course.pl, it is ambiguous
but the code is short and clean so I understand this choice.
- add_items-step1.tt and add_items-step2.tt could be merged into 1 template
- It would be easier to use DataTable for the course reserves list. Thus the
search form would have become useless
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
