https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26424
--- Comment #11 from Fridolin SOMERS <[email protected]> --- (In reply to Katrin Fischer from comment #9) > Please check the fail from the QA script: > > FAIL svc/checkouts > FAIL critic > # Variables::ProhibitConditionalDeclarations: Got 2 > violation(s). Oh indeed i see. Its a minor change : - my $type_for_stat = Koha::ItemTypes->find( $item_level_itypes ? $c->{itype} : $c->{itemtype} ); - my $itemtype = Koha::ItemTypes->find( $c->{itype} ); - my $recordtype = Koha::ItemTypes->find( $c->{itemtype} ); + my ( $itemtype, $recordtype, $type_for_stat ); + $itemtype = $itemtypes->{ $c->{itype} } if $c->{itype}; + $recordtype = $itemtypes->{ $c->{itemtype} } if $c->{itemtype}; + $type_for_stat = $item_level_itypes ? $itemtype : $recordtype; I replaced the patch -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
