https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
--- Comment #39 from Tomás Cohen Arazi <[email protected]> --- (In reply to Andrew Isherwood from comment #38) > (In reply to Katrin Fischer from comment #36) > > 1 & 2) > > > There is a strong pattern in the patches, file names, the API path of > > patron-renewals. Tbh, I wonder if this is not misleading. I'd expect > > something to do with membership renewals for patrons here. I wonder if we > > should add the checkout aspect here. > > I agree it could be misleading. I think your suggestion of an alternative > API route makes sense. Looking at the spec I created, I had the patron_id as > an optional parameter, though I'm not sure that makes sense, I can't think > of any case where you'd want to retrieve *all* a patron's renewals. I'm > going to retain the "embed" optional parameter as I do think this is useful. > So, to summarise, I'll change the route to: > > GET > /patrons/{patron_id}/checkouts/{checkout_id}/renewals(?embed=patron, > renewed_by) use the x-koha-embed header instead. > 3) Is there a strong reason to favor action_logs over statistics here? Let's make renewals be new checkout types hehe. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
