https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784
--- Comment #53 from Alexis Ripetti <[email protected]> --- (In reply to Jonathan Druart from comment #52) > 1. The second patch "Add tests" adds a change to the module, is that > expected? > > 2. You are modifying a test that is not (at first glance) directly related > to your changes, why? > >3. 1. As I said in a previous comment, the change in the C4/Circulation.pm file should have been applied on the main patch. 2. I was waiting for an answer of Arthur Suzuki about the test who should fail. I think that I corrected this test to pass but it may need to fail ? I am still waiting for an answer about the comment 49. 3. We can just modify the comment : # there's no overdue on the item but borrower is debarred -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
