http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7991

Paul Poulain <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |[email protected]

--- Comment #6 from Paul Poulain <[email protected]> ---
QA comment: tiny patch, passes perlcritic & koha-qa.pl

MARC21 comment(s):

* Jared, what do you mean by:
> As this view has never worked with MARC21, I am comfortable signing
> off on the fact that the patch does not in any way impact the MARC21
> display.

* Looking at the patch, I see something is added, I see:
  +      $row_data{itemcallnumber} = $marcflavour eq 'UNIMARC'
  +          ? $lc_field->subfield('a') # 930$a
  +          : $lc_field->subfield('h') # 852$h
  +          if ($sc_field->subfield('5') eq $lc_field->subfield('5'));
In MARC21, there is no $5 field, so I think this code does nothing for MARC21

As Jared says this tab does not work at all, I'm marking passed QA, but I'd
like to make this tab working for MARC21 too.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to