http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560
Paul Poulain <paul.poul...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
CC| |paul.poul...@biblibre.com
--- Comment #8 from Paul Poulain <paul.poul...@biblibre.com> ---
QA comment:
shouldn't
+=head2 GetTotalFines
+
+ my $total_fines_owed = GetTotalFines( $borrowernumber );
+
+ Returns the total amount owed by the given borrower.
be in C4/Accounts.pm more than in C4/Overdues.pm ?
I know there is calcfine and UpdateFine in C4/Overdues.pm, but I think it's a
mistake !
If you agree with me and move GetTotalFines to C4/Accounts.pm, you're welcomed
to factorize getcharges, getcredits, getrefunds, that are Getting things in
accountlines table. Note this is not requested for earning QA, just a
suggestion
You're also welcomed to name your sub GetFines, as GetSomethings() is already
supposed to return a list of something, so the "Total" is useless
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
