https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Kyle M Hall <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111317|0                           |1
        is obsolete|                            |
 Attachment #111318|0                           |1
        is obsolete|                            |
 Attachment #112102|0                           |1
        is obsolete|                            |

--- Comment #130 from Kyle M Hall <[email protected]> ---
Created attachment 112160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112160&action=edit
Bug 26751: Fix fatal exception if only one repo defined

This patch fixes this nasty problem with how XML is parsed: if more than
one entry is found, repo => [] is generated. If only one, repo => {}.

To test:
1. Have more than one entries in the plugins_repo entry:

<plugin_repos>
    <repo>
        <name>ByWater Solutions</name>
        <org_name>bywatersolutions</org_name>
        <service>github</service>
    </repo>
    <repo>
        <name>Theke Solutions</name>
        <org_name>thekesolutions</org_name>
        <service>github</service>
    </repo>
    <repo>
        <name>PTFS Europe</name>
        <org_name>ptfs-europe</org_name>
        <service>github</service>
    </repo>
 </plugin_repos>

2. Search for plugins
=> SUCCESS: Searching works!
3. Leave only one entry
4. Restart all to refresh things
5. Try searching for plugins
=> FAIL: Fatal error
6. Apply this patch
7. Repeat 5
=> SUCCESS: It doesn't explode anymore!
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <[email protected]>
Signed-off-by: Kyle M Hall <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>

Signed-off-by: Jonathan Druart <[email protected]>

Signed-off-by: Kyle M Hall <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to