https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #139 from David Cook <[email protected]> --- (In reply to Katrin Fischer from comment #138) > (In reply to David Cook from comment #137) > > (In reply to Jonathan Druart from comment #135) > > > It's coming from the default value in DB, why did you default to 0? I > > > think > > > it should default to 1. > > > > I think defaulting to 1 would be logical, but that would also be a change in > > system behaviour, since previously only patron categories C and P could be > > guaranteed it seems. > > > > Maybe it's a case where the default should be 1, but we set it to 0 for > > non-C and non-P patrons when doing a database update... > > But that's exactly what this patch does: > $dbh->do("UPDATE categories SET canbeguarantee = 1 WHERE category_type = 'P' > OR category_type = 'C'"); > No, that does the opposite of what I describe. I'm saying that the schema default should be 1 but then there should be a update patch to do the following: $dbh->do("UPDATE categories SET canbeguarantee = 0 WHERE category_type NOT IN ('P','C'); It's a subtle but significant difference. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
