https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012

--- Comment #5 from Joonas Kylmälä <[email protected]> ---
(In reply to Jonathan Druart from comment #2)
> Can you provide a test please?

I provided but I'm still against having those for old untested subroutines
because those are mostly very long and hard to provide tests for due to having
multiple functions combined in them and will have to go another round of
changes when moving to Koha namespace. Also I think it as a separate matter
that can be handled at another time and does not relate to the bug itself. This
would allow the testers and QA team to work on smaller tasks therefore allowing
higher chance of finding the time to review the code and pay more attention to
every detail in the patch compared to long patch set with multiple goals (in
this case: adding tests, fixing bug).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to