https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992

Joonas Kylmälä <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
             Status|Signed Off                  |Failed QA

--- Comment #10 from Joonas Kylmälä <[email protected]> ---
The commit title needs to tell what the commit does, not what the bug is
(<https://wiki.koha-community.org/wiki/Commit_messages#Examples>). Also the
formatting is not right, so something like

Bug 26992: Fix broken issues deletion on serial collection page

would be better.

Then I'm also wondering why there needs to be eval here:

> my $deleted_item = eval { $item->safe_delete };

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to