https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282
Josef Moravec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #12 from Josef Moravec <[email protected]> --- (In reply to Jonathan Druart from comment #11) > (In reply to Kyle M Hall from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > (In reply to Kyle M Hall from comment #7) > > > > Created attachment 113991 [details] [review] [review] [review] [review] > > > > Bug 26282: (QA follow-up) Always notify patron if notify checkbox is > > > > checked > > > > > > I am not sure we want that. I'd prefer to adjust the label of the checkbox > > > instead (or better, disable the checkbox if no option is selected). > > > What do you think? > > > > That is how it functioned previously. I'm not sure what you mean by > > adjusting the label of the checkbox. > > Previously what? > > On master there is: > if ( $params->{cancellation_reason} ) { > then send the notice > > So if no reason is chosen, no notice is sent. > > In my understanding, the limit of this bug report is to add the checkbox, > not to change this behaviour. > > My suggestion was to modify the label "Notify patron" with something like > "Notify patron if a reason is selected". > It's not optimal, and that's why I suggested to disable the checkbox until > an option was selected from the "reason" dropdown list. I do agree with you Jonathan - this is change in behaviour, and disabling checkbox when no reason is selected is definitely solution for this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
