https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488
--- Comment #131 from Jonathan Druart <[email protected]> --- (In reply to Joonas Kylmälä from comment #130) > (In reply to Martin Renvoize from comment #127) > > This looks like a great improvement, movin us to searching via objects > > etc... but... dare I say it, can we move this to a module and thus add > > tests? > > I think this definitely needs to use a module, the code population of > @all_items should be replaced with an object's method call that returns > items that can fill holds. Then it will make super easy to read code where > you just iterate over all the items and add the callnumber, shelving > location, etc. info to the $reserves variable that goes. Yes, it would be nice to have tests and make the code even more clean. But given from when we started, I think it's already a great improvement. I really would like to have this into master at the beginning of the release cycle, and I am not sure we are going to find volunteers to write tests soon... > Btw, to resolve the original issue, can't we just order by reserve priority? > This refactoring could be in a separate bug. No, I don't think it will work, because of the group by. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
