https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150
--- Comment #31 from Jonathan Druart <[email protected]> --- (In reply to Aleisha Amohia from comment #30) > I've made some starting changes to the notices to use Koha::Biblio objects > mostly (you can see it in the atomic update in the patch). > > I need some guidance/help with a few things: > - I wasn't sure where to get the dewey and classification info from It looks like they are always empty. It's broken since the following commit: commit af466ca41ab02150f4f6c60bf6262b079b2e6e85 Date: Thu Oct 18 18:53:52 2007 -0500 start of reworking call number handling and other Biblio changes IMO we should not reintroduce them on this bug report. > - I wasn't sure which notes field to use (biblioitems or biblio) It's coming GetBiblioData 729 my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan as bi_notforloan, biblio.notes So it's the 'notes' from biblio. > - the Author and Subjects subroutines are the hardest for me to refactor > because I'm not sure how different libraries use them Hum... Another weirdness. On opac-sendshelf: MARCSUBJCTS is set but not used in the template, 'subject' is used instead, but never sent from the pl... and it's the same for the other ones (sendbasket, sendshelf both OPAC and staff interfaces). I'd drop it as well. For MARCAUTHORS I'd try and write the equivalent of C4::Biblio::GetMarcAuthors in TT, and see how it goes (10 lines or 30 lines?). If it's too ugly then move to Koha::Biblio->get_MARC_authors (or get_authors_from_MARC?) > Some feedback would be great! Don't forget that you are in a quite dirty place. Don't loose time with things that are not working, drop them. I'd suggest that you focus on the simplest template first, no need to work in parallel on the four ones. Additional note, in your patch you are not looping at all on a Koha::Biblio set. As it's a WIP maybe you are aware of it, but I prefer to highlight it in case you missed it. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
